Skip to content

Commit

Permalink
Ignore dist files in repository, update PRtemplate (marktext#1894)
Browse files Browse the repository at this point in the history
* Ignore all permutations of dist in git

* Update PR template to direct contributors

The current template is largely being ignored with many PRs coming
through with "yes/no". Hopefully the text at the top will actually catch
peoples attention and keep the "clutter blindness" down that I think is
making people ignore the table entirely.

Also the note about dist files is pretty unnecessary with a properly
setup gitignore file.
  • Loading branch information
Caleb Maclennan authored Feb 6, 2020
1 parent 0aa0e04 commit 9b94834
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
7 changes: 3 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
<!-- Please change the Answers in the table below
to reflect the contents of your pull request. -->

| Q | A
| ---------------- | ---
| Bug fix? | yes/no
Expand All @@ -11,7 +14,3 @@
### Description

[Description of the bug or feature]

--

#### Please don't submit `/dist` files with your PR!
5 changes: 2 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
.DS_Store
dist/electron/*
dist/web/*
dist/
*/dist/*
build/*
static/themes/*
src/muya/dist/
src/muya/node_modules/
coverage
.vscode
Expand Down

0 comments on commit 9b94834

Please sign in to comment.