Skip to content

fix: nightly hardening - output format validation#20

Open
mouse-value-add wants to merge 1 commit intobrainsparker:mainfrom
mouse-value-add:chore/nightly-hardening-20260505-output-format-validation
Open

fix: nightly hardening - output format validation#20
mouse-value-add wants to merge 1 commit intobrainsparker:mainfrom
mouse-value-add:chore/nightly-hardening-20260505-output-format-validation

Conversation

@mouse-value-add
Copy link
Copy Markdown
Contributor

Problem

PromptLens currently accepts any values in and silently skips unknown formats during export. This can hide configuration mistakes and produce incomplete artifacts without clear feedback.

Approach

  • Added strict validation for against the supported set (, , , ).
  • Normalized configured formats by trimming whitespace and lowercasing values to make config input more resilient.
  • Added tests to verify normalization and explicit rejection of unsupported formats.

Verification

  • Ran a direct Python validation check to confirm:
    • normalizes to
    • unsupported values like raise validation errors.
  • Added to codify these checks.

Risks

  • Configurations that previously used unsupported format names (and were silently ignored) will now fail fast.

Rollback Plan

  • Revert this PR to restore previous permissive behavior, or relax validation to warnings if strict failure is too disruptive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant