Fix SSHSource trait bound error documentation and examples

[Copilot]

This PR addresses the trait bound error [u8]: SSHSource<'_> is not satisfied that occurs when attempting to use FlashConfig::dec() directly with raw byte slices.

Problem

The SSHSource trait in the sunset crate is only implemented for the internal DecodeBytes<'de> struct, not for raw [u8] or &mut [u8] types. When developers try to call FlashConfig::dec() directly:

// This causes: error[E0277]: the trait bound `[u8]: SSHSource<'_>` is not satisfied
let config: FlashConfig = FlashConfig::dec(&mut buf)?;

The error occurs because the trait system cannot find an implementation of SSHSource for the slice type.

Solution

The correct approach is to use the public API sshwire::read_ssh(), which internally creates the proper DecodeBytes struct that implements SSHSource:

// Correct usage - this works
let config: FlashConfig = sshwire::read_ssh(&buf, None)?;

Changes Made

• Added parse_flash_config_from_buffer() function demonstrating the correct usage pattern
• Added comprehensive documentation explaining the trait bound issue and its resolution
• Included clear examples showing the wrong vs. correct approaches
• Verified the solution compiles and builds successfully

Key Insight

The sunset crate's sshwire::read_ssh() function is the intended public interface for decoding SSH wire format data. It handles the creation of the internal DecodeBytes struct and proper error handling, while direct calls to .dec() methods bypass these protections and can lead to type system errors.

This fix ensures developers use the proper sunset crate API patterns and avoid low-level trait bound issues.

Created from VS Code via the GitHub Pull Request extension.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[brainstorm]

Accidental AI slop from VSCode, grrr