Increase priority of UART interrupt for ESP32/S2/S3 due to blocking.#60
Merged
Conversation
…riority3 as it was becoming blocked when reading the buffered uart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During testing of HSM I found that the ESP32 would be able to send unlimited bytes, but after a single byte was read, it would get blocked in both directions while reading the uart rx buffer.
ssh-stamp/src/espressif/buffered_uart.rs
Line 57 in ea17833
@projectgus found that esp-rtos runs at Priority 1 so the UART priority must be set higher than that. I tested at Priority 2 but the same block was occurring. Testing at Priority 3 (max) appears to work.
This PR should not affect anything else so can be easily merged.