Properly handle UART errors for a couple of unwraps#66
Conversation
|
i wrote a script that builds the firmware for esp32c6 and reports the file size comparing it to the main branch: firmware size of this branch: firmware size from main branch: |
…can suggest good ways to implement this feature
Turns out that we did experiment with a portable version of your script in the past: cargo-bloat ... unfortunately the symbol breakdown was quite broken for embedded targets, but yeah, perhaps your simple approach (just evaluating the size of the whole bin) works better for CI regressions. I'll look at integrating it. Or maybe cargo-bloatED or binsize might work better? 🤔 ... the idea being that instead of wondering what made a binary grow (regress), we could get a breakdown directly done on CI. |
|
@trufae Something like
... there seems to be a loooong tail of 0.0N% but I'm not sure that's well tallied up :_/ The total bin size seems to almost match your script output size (when stripped), since I'm using the Anyway, I think this perf/regression watch work belongs to issue #28, I have higher/critical issues to tackle now-now in #7 #62 #21 :_S |

No description provided.