Skip to content

Remove default max tokens (512) #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ankrgyl wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove default max tokens (512) #120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baf8c2b
Remove max tokens
ankrgyl Mar 1, 2025
5b914c2
remove null
ankrgyl Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions js/llm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import mustache from "mustache";

import { Score, Scorer, ScorerArgs } from "@braintrust/core";
import { ChatCache, OpenAIAuth, cachedChatCompletion } from "./oai";
import { ModelGradedSpec, templates } from "./templates";
Expand Down Expand Up @@ -111,7 +109,7 @@ export async function OpenAIClassifier<RenderArgs, Output>(

const extraArgs = {
temperature: temperature || 0,
max_tokens: maxTokens,
...(maxTokens !== undefined ? { max_tokens: Math.max(maxTokens, 5) } : {}),
};

const renderArgs = {
Expand Down Expand Up @@ -216,7 +214,6 @@ export function LLMClassifierFromTemplate<RenderArgs>({
const prompt =
promptTemplate + "\n" + (useCoT ? COT_SUFFIX : NO_COT_SUFFIX);

const maxTokens = 512;
const messages: ChatCompletionMessageParam[] = [
{
role: "user",
Expand All @@ -230,7 +227,6 @@ export function LLMClassifierFromTemplate<RenderArgs>({
choiceScores,
classificationTools: buildClassificationTools(useCoT, choiceStrings),
model,
maxTokens,
temperature,
__choices: choiceStrings,
...runtimeArgs,
Expand Down Expand Up @@ -281,6 +277,7 @@ function buildLLMClassifier<RenderArgs>(
return makePartial(
LLMClassifierFromSpecFile<RenderArgs>(
name,
// eslint-disable-next-line @typescript-eslint/consistent-type-assertions
templateName as keyof typeof templates,
),
name,
Expand Down Expand Up @@ -308,7 +305,7 @@ export const ClosedQA = buildLLMClassifier<{ input: string; criteria: any }>(
/**
* Test whether an output is funny.
*/
export const Humor = buildLLMClassifier<{}>("Humor", "humor");
export const Humor = buildLLMClassifier<unknown>("Humor", "humor");

/**
* Test whether an output is factual, compared to an original (`expected`) value.
Expand All @@ -330,7 +327,7 @@ export const Possible = buildLLMClassifier<{ input: string }>(
/**
* Test whether an output is malicious.
*/
export const Security = buildLLMClassifier<{}>("Security", "security");
export const Security = buildLLMClassifier<unknown>("Security", "security");

/**
* Test whether a SQL query is semantically the same as a reference (output) query.
Expand Down