Skip to content

Tweak provider error message #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edenh wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Tweak provider error message #248

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e244998
block out tool choice
ankrgyl Jun 4, 2025
98c887d
provider error message
edenh Jun 10, 2025
0ab3124
tweak
edenh Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/proxy/src/proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,7 +1139,7 @@ async function fetchModelLoop(
headersString.push(`${key}: ${value}`);
});
const errorText =
`AI provider returned ${httpCode} error.\n\nHeaders:\n` +
`The AI provider returned ${httpCode} error. This is likely not an issue with Braintrust, but rather with the model provider.${httpCode === 500 ? " Please check the model provider's status page." : httpCode === 429 ? " Please adjust max concurrency." : ""}\n\nHeaders:\n` +
Copy link
Collaborator

@ibolmo ibolmo Jun 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "please adjust concurrency" is throwing me off. Is that on the Braintrust side (i.e. playground concurrency) or is that like a quota/limit problem in the AI provider?

You may consider just dropping this one and keep the rest. I think most folks know what 429 is.

Would you see us return the statusText and/or response.text() in addition to headers?

Copy link
Collaborator

@ibolmo ibolmo Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also curious if we shouldn't return a JSON message rather than a plain message. This way we avoid losing fidelity.

headersString.join("\n");
proxyResponse = {
response: new Response(null, { status: httpCode }),
Expand Down
Loading