Skip to content

Conversation

@kevingosse
Copy link
Contributor

0.0.0.dirty is apparently not a valid version, it caused an error:

1>C:\Program Files\dotnet\sdk\8.0.417\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.GenerateAssemblyInfo.targets(226,5): error NETSDK1018: Invalid NuGet version string: '0.0.2.dirty'.

Copilot AI review requested due to automatic review settings January 21, 2026 18:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SDK/NuGet version generation to use a SemVer/NuGet-compatible “dirty workspace” suffix, avoiding invalid versions like 0.0.2.dirty.

Changes:

  • Replace .dirty suffix with -dirty when the git workspace is dirty.
  • Apply the same suffix change to the assembly version verification logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants