Add child span handling to OpenAIAgentsTraceProcessor#1361
Open
colinbennettbrain wants to merge 2 commits intomainfrom
Open
Add child span handling to OpenAIAgentsTraceProcessor#1361colinbennettbrain wants to merge 2 commits intomainfrom
colinbennettbrain wants to merge 2 commits intomainfrom
Conversation
…ement logic to end any open child spans when a trace ends. This addresses a potential race condition between onTraceEnd and onSpanEnd.
Ensure pre-commit formatting checks pass in CI by applying canonical line-wrapping to updated assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix updates OpenAIAgentsTraceProcessor.onTraceEnd() to end any child spans still tracked for the trace before deleting trace state, so spans don’t stay “in progress” if onTraceEnd runs before deferred onSpanEnd. It also adds regression tests covering the race path, late onSpanEnd no-op behavior, and multiple remaining child spans being closed correctly.