ref: Set no-unused-vars eslint rule to error and clean up violations#1407
Merged
AbhiPrasad merged 1 commit intomainfrom Feb 25, 2026
Merged
ref: Set no-unused-vars eslint rule to error and clean up violations#1407AbhiPrasad merged 1 commit intomainfrom
AbhiPrasad merged 1 commit intomainfrom
Conversation
c6abc27 to
f958ba7
Compare
f958ba7 to
8c297a8
Compare
Qard
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1406
AI Summary
why this change is important:
The
@typescript-eslint/no-unused-varsrule catches dead code — unused imports, variables, and type definitions that add noise, increase bundle size (for non-type imports), and make the codebase harder to maintain. Promoting it from"warn"to"error"means:CodeBundleSchema,RepoInfoSchema) that were never used, only their TypeScript types were needed. These unused runtime imports could pull in unnecessary code.serializeModel,SdkMcpToolDefinition, andHookEventwere defined but never referenced anywhere, creating confusion about whether they're part of the API surface.