Skip to content

ref: Set prefer-const eslint rule to error#1410

Merged
AbhiPrasad merged 1 commit intomainfrom
abhi-prefer-const-error
Feb 26, 2026
Merged

ref: Set prefer-const eslint rule to error#1410
AbhiPrasad merged 1 commit intomainfrom
abhi-prefer-const-error

Conversation

@AbhiPrasad
Copy link
Member

resolves #1409

AI Summary

js/eslint.config.ts: Changed "prefer-const": "warn" to "prefer-const": "error" (and removed the TODO comment).

js/src/logger.ts — 3 violations fixed:

  1. Line 1773: Renamed spread variable to rawUpdateEvent and assigned filtered result to a new const updateEvent, since the original was being reassigned.
  2. Line 5196: Changed for (let [name, score] to for (const [name, rawScore] with a let score = rawScore inside the loop body, since score is reassigned but name isn't.
  3. Line 5839: Changed let { summarizeScores, comparisonExperimentId } destructuring to const with renaming (comparisonExperimentIdOpt), then added a let comparisonExperimentId since it's reassigned later.

@AbhiPrasad AbhiPrasad self-assigned this Feb 25, 2026
@AbhiPrasad AbhiPrasad merged commit d252fe1 into main Feb 26, 2026
37 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-prefer-const-error branch February 26, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix prefer-const eslint violations

2 participants