Skip to content

ref: Set @typescript-eslint/prefer-as-const lint rule from warn to error #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lforst merged 1 commit into from
Mar 2, 2026
Merged

ref: Set @typescript-eslint/prefer-as-const lint rule from warn to error #1458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions js/eslint.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@ export default [
"@typescript-eslint/no-empty-object-type": "warn",
// TODO: Fix violations and re-enable as "error"
"@typescript-eslint/no-unsafe-function-type": "warn",
// TODO: Fix violations and re-enable as "error"
"@typescript-eslint/prefer-as-const": "warn",
"@typescript-eslint/prefer-as-const": "error",
// Require node: protocol for Node.js built-in imports (for Deno compatibility)
// This plugin automatically detects ALL Node.js built-ins - no manual list needed!
"node-import/prefer-node-protocol": "error",
Expand Down
4 changes: 2 additions & 2 deletions js/src/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2155,7 +2155,7 @@ export class Logger<IsAsyncFlush extends boolean> implements Exportable {
private calledStartSpan: boolean;

// For type identification.
public kind: "logger" = "logger";
public kind = "logger" as const;

constructor(
state: BraintrustState,
Expand Down Expand Up @@ -6134,7 +6134,7 @@ export class SpanImpl implements Span {
private _rootSpanId: string;
private _spanParents: string[] | undefined;

public kind: "span" = "span";
public kind = "span" as const;

constructor(
args: {
Expand Down
Loading