Merged
Conversation
AbhiPrasad
force-pushed
the
abhi-cleanup-js-readme
branch
from
f5b53b7 to
40ae0a8
Compare
AbhiPrasad
force-pushed
the
abhi-cleanup-js-readme
branch
from
40ae0a8 to
2132a19
Compare
lforst
approved these changes
Mar 4, 2026
integrations/langchain-js/README.md
Outdated
| - Braintrust docs: [https://www.braintrust.dev/docs](https://www.braintrust.dev/docs) | ||
| - LangChain callback docs: [https://js.langchain.com/docs/how_to/#callbacks](https://js.langchain.com/docs/how_to/#callbacks) | ||
|
|
||
| ## Development |
Member
There was a problem hiding this comment.
Do we need this section? May be better in a contributing md.
integrations/val.town/README.md
Outdated
Comment on lines
+13
to
+15
| ## Examples | ||
|
|
||
| ### Tutorial |
Member
There was a problem hiding this comment.
This header structure feels weird
js/CLAUDE.md
Outdated
Comment on lines
+8
to
+16
| make test # Full JS test suite (core + wrappers) | ||
| make test-core # Core tests only | ||
| make test-openai # OpenAI wrapper | ||
| make test-anthropic # Anthropic wrapper | ||
| make test-openai # OpenAI wrapper matrix tests | ||
| make test-anthropic # Anthropic wrapper matrix tests | ||
| make test-google-genai # Google GenAI wrapper tests | ||
| make test-ai-sdk # AI SDK wrapper tests (v5 + v6) | ||
| make test-vitest # Vitest wrapper tests | ||
| make test-claude-agent-sdk # Claude Agent SDK wrapper tests | ||
| make test-api-compat # API compatibility test |
Member
There was a problem hiding this comment.
I feel like our tests run fast enough to let our agents just run make test
Member
Author
There was a problem hiding this comment.
yeah I'll change that. But when we remove the makefile we'll come back to this anyway.
README.md
Outdated
Comment on lines
+61
to
+65
| ## Repository History | ||
|
|
||
| This repository was previously named `braintrust-sdk` and was renamed to `braintrust-sdk-javascript`. | ||
|
|
||
| The rename happened when Python SDK code was split out of this repository. The Python code now lives in the dedicated [`braintrust-sdk-python`](https://github.com/braintrustdata/braintrust-sdk-python) repository, and this repo is now JavaScript-focused. |
Member
There was a problem hiding this comment.
I think this is redundant to some degree. Wdyt?
Member
Author
There was a problem hiding this comment.
yeah lemme clean that up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves https://linear.app/braintrustdata/issue/BRA-4272/update-readme-to-link-new-python-repo-for-braintrust-sdk