ci: Run nightly canary release for braintrust package#1547
ci: Run nightly canary release for braintrust package#1547Abhijeet Prasad (AbhiPrasad) merged 1 commit intomainfrom
Conversation
Abhijeet Prasad (AbhiPrasad)
force-pushed
the
abhi-canary-nightly
branch
3 times, most recently
from
9aa23fe to
481a0a5
Compare
Abhijeet Prasad (AbhiPrasad)
changed the title
Luca Forstner (lforst)
left a comment
Luca Forstner (lforst)
left a comment
There was a problem hiding this comment.
Turns out the github package registry is very annoying. We just publish to npm instead. We also don't publish github releases or git tags for now, but we can change that decision at a later date.
To some degree I think we should keep these canaries in npm only. Whenever I see these things in GitHub releases I am annoyed af.
| await github.rest.actions.createWorkflowDispatch({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| workflow_id: "publish-js-sdk.yaml", |
There was a problem hiding this comment.
naive question but why this indirection?
There was a problem hiding this comment.
Ah for the canary input 🧠 maybe smol comment?
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 | ||
| with: | ||
| node-version: "20" | ||
| node-version: "22" |
There was a problem hiding this comment.
low key want to use volta cause the setup node action understands it
There was a problem hiding this comment.
Looks like we can provide a node-version-file to the setup action. Lemme clean this up.
There was a problem hiding this comment.
I'll fix this in a follow up PR after #1548 merges in
Abhijeet Prasad (AbhiPrasad)
force-pushed
the
abhi-canary-nightly
branch
from
481a0a5 to
5320db7
Compare
2 participants
resolves #1543
This PR publishes a nightly canary release of the
braintrustjs package. Read throughPUBLISHING_JS.md, it has all the info you need.We publish the package to the github package registry instead of npm, to keep npm clean for our actual stable/intentional pre-releases.Turns out the github package registry is very annoying. We just publish to npm instead. We also don't publish github releases or git tags for now, but we can change that decision at a later date.We have to do all the publishing from a single workflow because npm trusted publishing relies on that.