fix: Multi turn evaluation causes JSON serialization error#62
Open
ViaDézo1er (viadezo1er) wants to merge 2 commits intomainfrom
Open
fix: Multi turn evaluation causes JSON serialization error#62ViaDézo1er (viadezo1er) wants to merge 2 commits intomainfrom
ViaDézo1er (viadezo1er) wants to merge 2 commits intomainfrom
Conversation
ViaDézo1er (viadezo1er)
force-pushed
the
cedric/json-serialization-error-multi-turn-evaluation
branch
from
c6dca9e to
de0f896
Compare
ViaDézo1er (viadezo1er)
force-pushed
the
cedric/json-serialization-error-multi-turn-evaluation
branch
from
de0f896 to
2bbef0d
Compare
ViaDézo1er (viadezo1er)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Olmo Maldonado (ibolmo)
Abhijeet Prasad (AbhiPrasad)
approved these changes
Mar 10, 2026
|
|
||
| resp = proxy_conn().post("function/invoke", json=request, headers=headers, stream=stream) | ||
| request = bt_dumps(request) | ||
| resp = proxy_conn().post("function/invoke", data=request, headers=headers, stream=stream) |
There was a problem hiding this comment.
so it's important to note that switching from json=request to data=request will mean we no longer set Content-Type: application/json when sending the request. I'd double check if this is okay. If it is, feel free to merge!
Abhijeet Prasad (AbhiPrasad)
requested changes
Mar 10, 2026
Member
Abhijeet Prasad (AbhiPrasad)
left a comment
Abhijeet Prasad (AbhiPrasad)
left a comment
There was a problem hiding this comment.
Oh yeah, let's also add a regression test for this - I'm actually going to block until we add that.
Co-authored-by: Abhijeet Prasad <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #38
Deserialize JSON using Braintrust custom deserialization function (bt_dumps from bt_json), allowing to deserialize the ChatCompletionMessage objects.