add package manager option #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Braintrust eval reportSay Hi Bot Python (add-package-manager-1751934197)
|
Braintrust eval reportSay Hi Bot (add-package-manager-1751934202)
|
Braintrust eval reportConsole logging (add-package-manager-1751934204)
My Evaluation (add-package-manager-1751934204)
Say Hi Bot (add-package-manager-1751934204)
|
Braintrust eval reportSay Hi Bot (add-package-manager-1751934209)
|
ibolmo
force-pushed
the
add-package-manager
branch
from
34ecc62 to
bb949ca
Compare
Braintrust eval reportSay Hi Bot Python (add-package-manager-1751934196)
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
ibolmo
force-pushed
the
add-package-manager
branch
7 times, most recently
from
c77bfc9 to
472d62a
Compare
ibolmo
force-pushed
the
add-package-manager
branch
from
472d62a to
5d9a09d
Compare
daviddkkim
reviewed
Jul 7, 2025
| "The package manager to use for evals. Valid values: npm, pnpm, yarn, pip, | ||
| or uv depending on the runtime." | ||
| required: false | ||
| default: "" |
Contributor
There was a problem hiding this comment.
Should we define a default? it looks like if package_manager is "", it goes into an empty case statement
Contributor
Author
There was a problem hiding this comment.
yeah it's a bit odd, but it's for backward compatibility. I could try without the default '', but ultimately in the code it will fall back to '' due to the zod parsing
daviddkkim
reviewed
Jul 7, 2025
| switch (args.runtime.toLowerCase().trim()) { | ||
| case "node": | ||
| switch (args.package_manager) { | ||
| case "": |
Contributor
There was a problem hiding this comment.
Wondering if default should be defined and this should be removed -- what happens in this empty case?
Contributor
Author
There was a problem hiding this comment.
yeah for backward compatibility it'll be whatever we were doing before. so for node it'll be npx and for python it'll be pip. is that what you had in mind? right now it's just a switch case aliased to npm
Contributor
There was a problem hiding this comment.
yeet i forgot about the case statement behavior on no returns -- this makes sense
daviddkkim
approved these changes
Jul 7, 2025
Contributor
daviddkkim
left a comment
daviddkkim
left a comment
There was a problem hiding this comment.
Looks good -- just came across an error with yarn.
plz fix when you are ready!
Braintrust eval reportSay Hi Bot Python (main-1751936261)
|
Braintrust eval reportSay Hi Bot Python (main-1751936260)
|
Braintrust eval reportConsole logging (main-1751936265)
My Evaluation (main-1751936265)
|
Braintrust eval reportSay Hi Bot (main-1751936265-955e18da)
|
Braintrust eval report
|
Braintrust eval reportSay Hi Bot Python ([email protected])
|
Braintrust eval reportSay Hi Bot Python ([email protected])
|
Braintrust eval reportSay Hi Bot Python ([email protected])
|
Braintrust eval reportSay Hi Bot Python ([email protected])
|
Braintrust eval reportConsole logging (HEAD-1751936460)
My Evaluation (HEAD-1751936460)
|
Braintrust eval reportSay Hi Bot (HEAD-1751936460-18369f47)
|
Braintrust eval report
|
Braintrust eval reportConsole logging (HEAD-1751936469)
My Evaluation (HEAD-1751936469)
|
Braintrust eval reportSay Hi Bot (HEAD-1751936469-91b995a0)
|
Braintrust eval report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.