forward client headers for providers #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knjiang
force-pushed
the
01-17-forward_client_headers
branch
6 times, most recently
from
6cebe24 to
187ec78
Compare
knjiang
commented
Jan 18, 2026
Comment on lines
+35
to
+54
| /// Header prefixes blocked from forwarding to upstream LLM providers. | ||
| pub const BLOCKED_HEADER_PREFIXES: &[&str] = &["x-amzn", "x-bt", "sec-"]; | ||
|
|
||
| /// Exact header names blocked from forwarding to upstream LLM providers | ||
| /// from https://github.com/braintrustdata/braintrust-proxy/blob/e992f51734c71e689ea0090f9e0a6759c9a593a4/packages/proxy/src/proxy.ts#L247 | ||
| pub const BLOCKED_HEADERS: &[&str] = &[ | ||
| "authorization", | ||
| "api-key", | ||
| "x-api-key", | ||
| "x-auth-token", | ||
| "content-length", | ||
| "origin", | ||
| "priority", | ||
| "referer", | ||
| "user-agent", | ||
| "cache-control", | ||
| // Avoid forwarding client Accept-Encoding: upstream may return compressed bytes we | ||
| // don't decode (e.g., unsupported encodings), which breaks JSON parsing in the router. | ||
| "accept-encoding", | ||
| ]; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
main code that is similar to https://github.com/braintrustdata/braintrust-proxy/blob/main/packages/proxy/src/proxy.ts#L247
the only addition is accept-encoding which i was running into issues with since we don't have any feature crates on.
should we turn on gzip? -> https://docs.rs/reqwest/latest/reqwest/struct.ClientBuilder.html it seems to be a feature for reqwest and i think the LLM apis support it.
Comment on lines
+98
to
+99
| // Respect caller override: only set default if missing. | ||
| if !headers.contains_key(ANTHROPIC_BETA) { |
Contributor
Author
There was a problem hiding this comment.
auto-adding structured outputs since it seems useful esp. for chat completions response_format -> anthropic.
also seems hard coded in their sdk -> https://github.com/anthropics/anthropic-sdk-python/blob/main/src/anthropic/resources/beta/messages/messages.py#L1106
knjiang
force-pushed
the
01-17-forward_client_headers
branch
from
187ec78 to
403ea78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forwards client headers into lingua with proxy-style filtering and dedupe JSON header setup; filtering similar to proxy.ts -> https://github.com/braintrustdata/braintrust-proxy/blob/main/packages/proxy/src/proxy.ts#L247