Fix/evaluation bugs#15
Open
R09722akaBennett wants to merge 7 commits into
Open
Conversation
## UnicodeDecodeError Fix for Windows ### Problem On Windows systems, the default encoding (cp1252) can cause UnicodeDecodeError when reading files containing non-ASCII characters. This breaks functionality for Windows users working with international text. ### Solution This PR modifies the `_get_chunks_and_metadata` method to detect Windows environments and explicitly use UTF-8 encoding when opening files on that platform. The behavior on other platforms remains unchanged. ### Testing Tested on: - Windows 10 with files containing Unicode characters (previously errored, now works) - Linux with the same files (behavior unchanged) This change is minimally invasive but fixes a significant usability issue for Windows users.
…icodeDecodeErrorOnWindows Update base_evaluation.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a bugs encountered during the evaluation run:
Closes #13