Replace request with fetch
#528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonok-edm
requested review from
fmarier,
diracdeltas,
petemill and
simonhong
|
This should also fix the issue with the Estonian regional adblock list I noted in #380 (comment) |
diracdeltas
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
change lgtm but CI is failing with a node gyp error: https://github.com/brave/brave-core-crx-packager/actions/runs/3643168897/jobs/6151103409
|
Also of note: we'd need to run this in Node 18 ( |
|
@diracdeltas looks like a Python 2->3 error.
I'm not sure what's causing that specifically, but I assume Node 18 has a better chance of handling Python 3 correctly, too. |
mihaiplesa
force-pushed
the
replace-request-with-fetch
branch
from
4199e1f to
4427f0a
Compare
|
I see that |
mihaiplesa
force-pushed
the
replace-request-with-fetch
branch
from
4427f0a to
f0a6ddf
Compare
mihaiplesa
approved these changes
Dec 14, 2022
|
This is good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
requestpackage is deprecated and unmaintained. The same functionality can be achieved with the built-infetchAPI, so I removed the dependency and updated the code accordingly.Progress towards #380.