Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetch calls to use .then instead of callback argument #539

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Fix fetch calls to use .then instead of callback argument #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ntpUtil.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ const prepareAssets = (jsonFileUrl, targetResourceDir, targetJsonFileName) => {

// Download and parse jsonFileUrl.
// If it doesn't exist, create with empty object.
fetch(jsonFileUrl, async function (response) {
fetch(jsonFileUrl).then(async function (response) {
if (response.status === 200) {
jsonFileBody = await response.text()
}
Expand Down
2 changes: 1 addition & 1 deletion scripts/generateBraveAdsResourcesComponentInputFiles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ const getComponentList = () => {
function downloadComponentInputFiles (manifestFileName, manifestUrl, outDir) {
return new Promise(function (resolve, reject) {
let manifestBody = '{}'
fetch(manifestUrl, async function (response) {
fetch(manifestUrl).then(async function (response) {
if (response.status === 200) {
manifestBody = await response.text()
}
Expand Down
2 changes: 1 addition & 1 deletion scripts/generateNTPBackgroundImages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const prepareAssets = (jsonFileUrl, targetResourceDir) => {
let body = '{}'

// Download and parse jsonFileUrl.
fetch(jsonFileUrl, async function (response) {
fetch(jsonFileUrl).then(async function (response) {
if (response.status !== 200) {
throw new Error(`Error from ${jsonFileUrl}: ${response.status} ${response.statusText}`)
}
Expand Down
2 changes: 1 addition & 1 deletion scripts/generateNTPSuperReferrerMappingTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function downloadMappingTableJsonFile (jsonFileUrl, targetFilePath) {
return new Promise(function (resolve, reject) {
let jsonFileBody = '{}'

fetch(jsonFileUrl, async function (response) {
fetch(jsonFileUrl).then(async function (response) {
if (response.status === 200) {
jsonFileBody = await response.text()
}
Expand Down