You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I haven't used Android Studio and haven't had a chance to look at this in detail yet, but in principle this seems fine.
There are a couple of superficial issues that stand out:
I don't think it's a good idea to vendor-in the whole Rubber Band Library tree. Previously this repo used a Mercurial subrepo to acquire the Rubber Band code. Clearly that won't work now that most people probably get the code from Github, so (in the default branch) I've just added a line in the README suggesting to check out the library code in the appropriate subdirectory. I think an instruction like that should probably be enough.
However, I'm guessing that this will only work if the Rubber Band Library code includes the CMake build spec that you proposed in a separate PR for Rubber Band; unless that (or something compatible) is in the Rubber Band repo, then it's necessary to have a separate copy. Is that right? Again I'd be happy to see an updated Android-compatible build script in the library repo, but there are currently two apparently conflicting submissions of CMakeLists.txt files that need to be resolved in there first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.