Skip to content

convert to Android Studio Project#2

Open
mgood7123 wants to merge 5 commits intobreakfastquay:masterfrom
mgood7123:master
Open

convert to Android Studio Project#2
mgood7123 wants to merge 5 commits intobreakfastquay:masterfrom
mgood7123:master

Conversation

@mgood7123
Copy link

No description provided.

@mgood7123
Copy link
Author

mgood7123 commented Jan 13, 2020

changed ratio to 3.5 and pitchshift to 2 to make it more noticable that rubberband actually works in the demo

@cannam
Copy link
Member

cannam commented Jan 16, 2020

Hi there - thanks for the proposal!

I haven't used Android Studio and haven't had a chance to look at this in detail yet, but in principle this seems fine.

There are a couple of superficial issues that stand out:

  • I don't think it's a good idea to vendor-in the whole Rubber Band Library tree. Previously this repo used a Mercurial subrepo to acquire the Rubber Band code. Clearly that won't work now that most people probably get the code from Github, so (in the default branch) I've just added a line in the README suggesting to check out the library code in the appropriate subdirectory. I think an instruction like that should probably be enough.

  • However, I'm guessing that this will only work if the Rubber Band Library code includes the CMake build spec that you proposed in a separate PR for Rubber Band; unless that (or something compatible) is in the Rubber Band repo, then it's necessary to have a separate copy. Is that right? Again I'd be happy to see an updated Android-compatible build script in the library repo, but there are currently two apparently conflicting submissions of CMakeLists.txt files that need to be resolved in there first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants