Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test suite under Sphinx 7.4+ #1007

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Conversation

yut23
Copy link
Contributor

@yut23 yut23 commented Jan 16, 2025

The source of this issue is sphinx-doc/sphinx#12492, which changed how directive content gets parsed. Previously, it went through SphinxDirective.state.nested_parse() which MockState implements as a no-op, so content was never used.

Closes #987.

@yut23 yut23 force-pushed the sphinx_7.4_compat branch from 48fe6f0 to 47fe4a8 Compare January 16, 2025 04:09
@AA-Turner
Copy link
Collaborator

@yut23 thanks for the PR Eric, would you be able to update it to ignore the Docutils warnings?

A

yut23 added 2 commits January 16, 2025 10:30
This method was added in docutils 0.18, which our minimum version of
Sphinx 6.2.0 requires.
@AA-Turner
Copy link
Collaborator

    def update(app: Sphinx, source_file: str | os.PathLike[str]) -> None:
E   TypeError: unsupported operand type(s) for |: 'type' and 'types.GenericAlias'

Could you add a from __future__ import annotations import?

@yut23
Copy link
Contributor Author

yut23 commented Jan 16, 2025

I was going to fix all the linter errors in another PR, and only touch the tests here.

@AA-Turner
Copy link
Collaborator

This is a test error in Python 3.9

@yut23
Copy link
Contributor Author

yut23 commented Jan 16, 2025

Fair enough, should be fixed now.

@AA-Turner AA-Turner merged commit 44c1136 into breathe-doc:main Jan 16, 2025
22 of 27 checks passed
@AA-Turner
Copy link
Collaborator

Thanks Eric!

A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test suite fails with sending None to string2lines() in Sphinx
2 participants