-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test suite under Sphinx 7.4+ #1007
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make the test suite pass in CI.
48fe6f0
to
47fe4a8
Compare
AA-Turner
approved these changes
Jan 16, 2025
@yut23 thanks for the PR Eric, would you be able to update it to ignore the Docutils warnings? A |
This method was added in docutils 0.18, which our minimum version of Sphinx 6.2.0 requires.
Could you add a |
I was going to fix all the linter errors in another PR, and only touch the tests here. |
This is a test error in Python 3.9 |
Fair enough, should be fixed now. |
Thanks Eric! A |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source of this issue is sphinx-doc/sphinx#12492, which changed how directive content gets parsed. Previously, it went through
SphinxDirective.state.nested_parse()
whichMockState
implements as a no-op, socontent
was never used.Closes #987.