Fix errors in template specialization with qualified arguments #1012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the problem mentioned in the TODO comment in
sphinxrenderer.py
, which I ran into with this piece of code: https://github.com/AMReX-Astro/Microphysics/blob/b7fa023216305edce0ea4a8cff60e6a781a69400/util/microphysics_autodiff.H#L229-L234The change in
sphinxrenderer.py
fixes the class name being cut off inside the template argument, corresponding to this warning:The change in
filter.py
fixes the class being duplicated outside its namespace, corresponding to these errors and warnings:Before and after screenshots