Skip to content

Conversation

@jirutka
Copy link

@jirutka jirutka commented Feb 19, 2025

Please see commit messages.

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

`hasSeconds` has type `boolean`, the same is in the documentation, so
using `boolean()` is unnecessary.

Moreover, the "boolean" package is marked as deprecated on npmjs.org.
This package must be a joke, it contains literally three lines of code
and another dependency - is-string-blank.

The is-string-blank package is 6 years old and the source repository is
gone. Moreover, it can be replaced with just a single line of code -
it's used to check just a very short strings so the performance
difference is negligible, if it still exists.
is-valid-path is literally just `isInvalidPath(value) === false`, so we
can use is-invalid-path directly and skip one unnecessary dependency.
@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: environment, filesystem, shell +26 1.17 MB okonet

🚮 Removed packages: npm/@tsconfig/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant