-
Notifications
You must be signed in to change notification settings - Fork 28
Bref v3 #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mnapoli
wants to merge
12
commits into
main
Choose a base branch
from
v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor to a single layer * Fix * Fixes * Finish merging php.ini files * Update the PHP 8.2 and 8.3 build scripts too
* Optimize layer sizes The goal is to reduce layer sizes to optimize cold starts (that's the theory at least). - `strip` debug symbols for all libraries and PHP extensions (saves 11.7%) - compile PHP with the `-Os` C/CPP flag to optimize the binary for size (saves 8%) - compile libraries with the `-Os` flag (saves 6.3%) - disable the `soap` extension by default to avoid loading it on PHP startup (the only big unpopular extension I could find) - bundle the `pdo-mysql` extension in the PHP binary: it is extra small and will avoid loading it through an external file (small optimization) In total that's a 24% size reduction, i.e. 14.6MB. This is for Bref v3, I will run some benchmarks as just measuring the layer size doesn't tell us the full story about cold starts. * Fix tests
# Conflicts: # layers/fpm-dev/Dockerfile # php-80/Dockerfile # php-81/Dockerfile
# Conflicts: # Makefile # php-80/Dockerfile # php-81/Dockerfile
…this value by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will contain all changes for Bref v3.
This PR goes hand-in-hand with brefphp/bref#1953
This will be a long-running PR, I like to keep this open for months so that we have a place to preview and discuss changes. I do not intend to merge this pull request soon.
Layers for v3 are published to a different AWS account than v2, to avoid conflict. That means we can start using v3 layers as soon as these are published (working on it).
Changes:
873528684822
)