Skip to content

Commit

Permalink
refactor: remove unused disable directives
Browse files Browse the repository at this point in the history
  • Loading branch information
brettz9 committed Sep 6, 2024
1 parent ff66013 commit 8718079
Show file tree
Hide file tree
Showing 32 changed files with 171 additions and 206 deletions.
1 change: 0 additions & 1 deletion babel.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Move to own repo so can have `@babel/eslint-parser` and
// `@babel/eslint-plugin` as deps.
/* eslint-disable jsdoc/imports-as-dependencies -- Bug? */

// Adapted from MIT-licensed: https://github.com/futagoza/eslint-config-futagozaryuu/blob/master/packages/%40futagoza/eslint-config-core/stylistic-issues.js

Expand Down
1 change: 0 additions & 1 deletion bare.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable jsdoc/imports-as-dependencies -- Bug */
import {builtinModules} from 'node:module';

/** @type {import('eslint').Linter.Config[]} */
Expand Down
1 change: 0 additions & 1 deletion browser.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable jsdoc/imports-as-dependencies -- Bug */
import eslintCompat from 'eslint-plugin-compat';
import esCompat from 'eslint-plugin-escompat';
// import noUnsanitized from 'eslint-plugin-no-unsanitized'; // Todo: Disable until https://github.com/mozilla/eslint-plugin-no-unsanitized/pull/239#issuecomment-2132867450
Expand Down
1 change: 0 additions & 1 deletion cypress.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable jsdoc/imports-as-dependencies -- Bug */
import cypress from 'eslint-plugin-cypress/flat';

import mochaPlus from './mocha-plus.js';
Expand Down
1 change: 0 additions & 1 deletion eslint.config.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable jsdoc/imports-as-dependencies -- Bug */

import index from './index.js';

Expand Down
1 change: 0 additions & 1 deletion explicitly-unused.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable jsdoc/imports-as-dependencies -- Bug */
/** @type {import('eslint').Linter.Config[]} */
export default [{
name: 'ash-nazg-internal/explicitly-unused',
Expand Down
1 change: 0 additions & 1 deletion great-eye-node.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable jsdoc/imports-as-dependencies -- Bug */
import greatEye from './great-eye.js';
import sauronNode from './sauron-node.js';

Expand Down
1 change: 0 additions & 1 deletion great-eye.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable jsdoc/imports-as-dependencies -- Bug */
import sauron from './sauron.js';

/**
Expand Down
1 change: 0 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable jsdoc/imports-as-dependencies -- Bug */
// Todo: Add TS config, including for use with JS!
// eslint-disable-next-line n/no-sync -- No async configs
import {readFileSync} from 'fs';
Expand Down
1 change: 0 additions & 1 deletion inherited-rules/build.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/* eslint quotes: ["error", "single"] -- not using JSON.stringify here */
/* eslint-disable n/no-sync, no-console -- build script so sync and
console ok */
/* eslint-disable jsdoc/imports-as-dependencies -- Bug? */

// Todo: Update for flat configs!

Expand Down
1 change: 0 additions & 1 deletion main.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable jsdoc/imports-as-dependencies -- Bug */
// import {fixupPluginRules} from '@eslint/compat'
// import {FlatCompat} from '@eslint/eslintrc';

Expand Down
1 change: 0 additions & 1 deletion mocha-plus.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable jsdoc/imports-as-dependencies -- Bug */

// Not technically flat: https://eslint.org/docs/latest/extend/plugin-migration-flat-config#migrating-environments-for-flat-config
// However, we don't need flat config--just to embed its globals
Expand Down
1 change: 0 additions & 1 deletion mocha.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Todo: Might move these very basic configs (Mocha, and add one for Node
// globals, etc.) to own repo
/* eslint-disable jsdoc/imports-as-dependencies -- Bug */

/** @type {import('eslint').Linter.Config[]} */
export default [{
Expand Down
1 change: 0 additions & 1 deletion modules.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable jsdoc/imports-as-dependencies -- Bug */
/** @type {import('eslint').Linter.Config[]} */
export default [{
name: 'ash-nazg/modules',
Expand Down
1 change: 0 additions & 1 deletion node.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable jsdoc/imports-as-dependencies -- Bug */
import globals from 'globals';
import nodePlugin from 'eslint-plugin-n';
import index from './main.js';
Expand Down
1 change: 0 additions & 1 deletion overrides-module.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable jsdoc/imports-as-dependencies -- Bug */

/** @type {import('eslint').Linter.Config[]} */
export default [
Expand Down
1 change: 0 additions & 1 deletion overrides-script.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable jsdoc/imports-as-dependencies -- Bug */

/** @type {import('eslint').Linter.Config[]} */
export default [
Expand Down
1 change: 0 additions & 1 deletion overrides.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable jsdoc/imports-as-dependencies -- Bug */
// eslint-disable-next-line n/no-sync -- For sync API
import {readFileSync} from 'fs';
import globals from 'globals';
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@
"@brettz9/eslint-plugin": "^3.0.0",
"@eslint-community/eslint-plugin-eslint-comments": "^4.4.0",
"@eslint/eslintrc": "^3.1.0",
"@eslint/js": "^9.9.1",
"@eslint/markdown": "^6.0.0",
"@eslint/js": "^9.10.0",
"@eslint/markdown": "^6.1.0",
"@fintechstudios/eslint-plugin-chai-as-promised": "^3.1.0",
"@stylistic/eslint-plugin": "^2.7.2",
"es-file-traverse": "^1.2.0",
Expand Down Expand Up @@ -103,9 +103,9 @@
"devDependencies": {
"@scottnonnenberg/eslint-compare-config": "^1.1.0",
"@types/eslint__js": "^8.42.3",
"@types/node": "^22.5.3",
"@types/node": "^22.5.4",
"@types/semver": "^7.5.8",
"eslint": "^9.9.1",
"eslint": "^9.10.0",
"rimraf": "^5.0.0",
"typescript": "^5.5.4"
}
Expand Down
Loading

0 comments on commit 8718079

Please sign in to comment.