Skip to content

Commit

Permalink
fix: ensure great eye passes on args
Browse files Browse the repository at this point in the history
Also:
- chore: update deps.
  • Loading branch information
brettz9 committed Sep 24, 2024
1 parent e01716b commit 8aa67e5
Show file tree
Hide file tree
Showing 6 changed files with 207 additions and 183 deletions.
5 changes: 5 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# eslint-config-ash-nazg CHANGES

## ?

- fix: ensure great eye passes on args
- chore: update deps.

## 36.17.1

- fix: properly disable overly aggressive sonarjs rules
Expand Down
6 changes: 3 additions & 3 deletions great-eye-node.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import sauronNode from './sauron-node.js';
/**
* @type {(pkg: {
* type?: "module"|"commonjs"
* }) => import('eslint').Linter.Config[]}
* }, types: string[]) => import('eslint').Linter.Config[]}
*/
export default function greatEyeNode (pkg) {
return [...greatEye(pkg), ...sauronNode(pkg)];
export default function greatEyeNode (pkg, types) {
return [...greatEye(pkg, types), ...sauronNode(pkg)];
}
6 changes: 3 additions & 3 deletions great-eye.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import sauron from './sauron.js';
/**
* @type {(pkg: {
* type?: "module"|"commonjs"
* }) => import('eslint').Linter.Config[]}
* }, types: string[]) => import('eslint').Linter.Config[]}
*/
export default function greatEye (pkg) {
return [...sauron(pkg), {
export default function greatEye (pkg, types) {
return [...sauron(pkg, types), {
name: 'ash-nazg/great-eye',
settings: {
preferredTypes: {
Expand Down
4 changes: 2 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,12 @@ export default function index (types, config) {

if (types.includes('great-eye')) {
if (types.includes('node')) {
configs.push(...greatEyeNode(pkg), {
configs.push(...greatEyeNode(pkg, types), {
name: 'ash-nazg/great-eye-node/languageOptions',
languageOptions
});
} else {
configs.push(...greatEye(pkg));
configs.push(...greatEye(pkg, types));
}
} else if (types.includes('sauron')) {
if (types.includes('node')) {
Expand Down
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"@brettz9/eslint-plugin": "^3.0.0",
"@eslint-community/eslint-plugin-eslint-comments": "^4.4.0",
"@eslint/eslintrc": "^3.1.0",
"@eslint/js": "^9.10.0",
"@eslint/js": "^9.11.1",
"@eslint/markdown": "^6.1.0",
"@fintechstudios/eslint-plugin-chai-as-promised": "^3.1.0",
"@stylistic/eslint-plugin": "^2.8.0",
Expand All @@ -85,12 +85,12 @@
"eslint-plugin-compat": "^6.0.1",
"eslint-plugin-cypress": "^3.5.0",
"eslint-plugin-escompat": "^3.11.1",
"eslint-plugin-html": "^8.1.1",
"eslint-plugin-html": "^8.1.2",
"eslint-plugin-import": "^2.30.0",
"eslint-plugin-jsdoc": "^50.2.2",
"eslint-plugin-jsdoc": "^50.2.4",
"eslint-plugin-mocha": "^10.5.0",
"eslint-plugin-mocha-cleanup": "^1.11.3",
"eslint-plugin-n": "^17.10.2",
"eslint-plugin-n": "^17.10.3",
"eslint-plugin-no-unsanitized": "^4.1.0",
"eslint-plugin-no-use-extend-native": "^0.7.2",
"eslint-plugin-promise": "^7.1.0",
Expand All @@ -105,9 +105,9 @@
"devDependencies": {
"@scottnonnenberg/eslint-compare-config": "^1.1.0",
"@types/eslint__js": "^8.42.3",
"@types/node": "^22.5.4",
"@types/node": "^22.6.1",
"@types/semver": "^7.5.8",
"eslint": "^9.10.0",
"eslint": "^9.11.1",
"rimraf": "^5.0.0",
"typescript": "^5.6.2"
}
Expand Down
Loading

0 comments on commit 8aa67e5

Please sign in to comment.