Skip to content

Commit

Permalink
fix: restore import plugin support
Browse files Browse the repository at this point in the history
  • Loading branch information
brettz9 committed Oct 19, 2024
1 parent d88c5ff commit db395ea
Show file tree
Hide file tree
Showing 8 changed files with 30 additions and 22 deletions.
7 changes: 3 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -735,10 +735,9 @@ can be picky about giving up their *preh-shus*...
## High-priority to-dos

1. Restore the following as may become available in flat config:
1. eslint-plugin-import
2. eslint-plugin-unsanitized
3. @fintechstudios/eslint-plugin-chai-as-promised (has PR)
4. eslint-plugin-mocha-cleanup (has PR)
1. eslint-plugin-unsanitized
2. @fintechstudios/eslint-plugin-chai-as-promised (has PR)
3. eslint-plugin-mocha-cleanup (has PR)

## To-dos

Expand Down
2 changes: 1 addition & 1 deletion cypress.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import cypress from 'eslint-plugin-cypress/flat';
import cypress from 'eslint-plugin-cypress';

import mochaPlus from './mocha-plus.js';

Expand Down
7 changes: 3 additions & 4 deletions great-eye.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,9 @@ export default function greatEye (pkg, types) {
]
}],

// Todo: Reenable when reapplied
// 'import/no-unused-modules': ['warn', {
// missingExports: true, unusedExports: true
// }],
'import/no-unused-modules': ['warn', {
missingExports: true, unusedExports: true
}],

'jsdoc/check-alignment': ['warn'],
'jsdoc/check-indentation': ['warn'],
Expand Down
7 changes: 5 additions & 2 deletions main.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,16 @@ import brettz9 from '@brettz9/eslint-plugin';
import markdown from '@eslint/markdown';
import html from 'eslint-plugin-html';
import promise from 'eslint-plugin-promise';
// import importPlugin from 'eslint-plugin-import';
import importPlugin from 'eslint-plugin-import';
import unicorn from 'eslint-plugin-unicorn';
import comments from '@eslint-community/eslint-plugin-eslint-comments/configs';

import arrayFunc from 'eslint-plugin-array-func';
import sonarjs from 'eslint-plugin-sonarjs';
import jsdoc from 'eslint-plugin-jsdoc';

// eslint-disable-next-line @stylistic/max-len -- Long
// eslint-disable-next-line import/namespace, import/default, import/no-named-as-default, import/no-named-as-default-member -- Experimental JSON
import noUseExtendNative from 'eslint-plugin-no-use-extend-native';

import script from './script.js';
Expand Down Expand Up @@ -59,7 +62,7 @@ export default function main (pkg) {

// These may override 'standard' which includes their rules,
// so including first
// ...compat.extends('plugin:import/recommended'), // Todo: Reenable after ESLint 9/Flat support: https://github.com/import-js/eslint-plugin-import/issues/2948
importPlugin.flatConfigs.recommended,
promise.configs['flat/recommended'],
// This may override eslint:recommended and the promise/import rules,
// but it doesn't turn any off
Expand Down
5 changes: 2 additions & 3 deletions sauron.js
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,8 @@ export default function sauron (pkg, types) {
],
'vars-on-top': ['warn'],

// Todo: Reenable after: https://github.com/import-js/eslint-plugin-import/issues/2948
// 'import/unambiguous': 'warn',
// 'import/no-commonjs': 'warn',
'import/unambiguous': 'warn',
'import/no-commonjs': 'warn',

'jsdoc/require-jsdoc': ['warn', {
require: {
Expand Down
13 changes: 6 additions & 7 deletions standard.js
Original file line number Diff line number Diff line change
Expand Up @@ -124,13 +124,12 @@ export default [{
'valid-typeof': 'error',
'@stylistic/wrap-iife': 'error',
'@stylistic/yield-star-spacing': 'error',
yoda: 'error'
// Todo: Reenable
// 'import/export': 'error',
// 'import/first': 'error',
// 'import/no-duplicates': 'error',
// 'import/no-named-default': 'error',
// 'import/no-webpack-loader-syntax': 'error'
yoda: 'error',
'import/export': 'error',
'import/first': 'error',
'import/no-duplicates': 'error',
'import/no-named-default': 'error',
'import/no-webpack-loader-syntax': 'error'
}
}, {
name: 'ash-nazg/standard/node',
Expand Down
2 changes: 1 addition & 1 deletion typings/eslint-plugin-cypress.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
declare module 'eslint-plugin-cypress/flat' {
declare module 'eslint-plugin-cypress' {
import type { Linter } from "eslint";

declare const cypress: {
Expand Down
9 changes: 9 additions & 0 deletions typings/eslint-plugin-import.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
declare module 'eslint-plugin-import' {
interface ConfigsStructure {
flatConfigs: {
recommended: import('eslint').Linter.Config
}
}
var importPlugin: ConfigsStructure
export = importPlugin;
}

0 comments on commit db395ea

Please sign in to comment.