Sherlock audit fixes

[will-brevis]

Temporary PR for an alternative web-view of changes made to the auditing branch.

[will-brevis]

For any auditors visiting this PR, the fix commit for 204 has a typo and is addressed in the fix for 233 (a similar issue).

The VM also no longer works, as we need to pull in some P3 updates for the updated FRI code and changed some lookups.

[CergyK]

Here are my comments on some of the fixes (please consider the others LGTM):

#144 -> Fix ok, here are some potentially similar issues (input length mismatch) which could be fixed with zip_eq?

https://github.com/brevis-network/pico/blob/sherlock-audit-fixes/vm/src/compiler/recursion/circuit/fri.rs#L271
https://github.com/brevis-network/pico/blob/sherlock-audit-fixes/vm/src/compiler/recursion/circuit/merkle_tree.rs#L150
https://github.com/brevis-network/pico/blob/sherlock-audit-fixes/vm/src/instances/compiler/riscv_circuit/convert/builder.rs#L274
https://github.com/brevis-network/pico/blob/sherlock-audit-fixes/vm/src/machine/verifier.rs#L93

#124 -> Outdated comment
https://github.com/brevis-network/pico/blob/sherlock-audit-fixes/gnark/koalabear/koalabear.go#L377-L378

#230 -> The assert is stripped out from the recursion program;
https://github.com/brevis-network/pico/blob/sherlock-audit-fixes/vm/src/compiler/recursion/circuit/stark.rs#L142

#233 -> Same here. Assert would be stripped out, so it brings no additional security guarantees

#226 -> Would need to update Cargo.lock in perf/bench_apps

[will-brevis]

Regarding #230 and #233, these are meant to be sanity checks to be performed by our official proof verifier, or anyone using our recursion machine builder. We do not want to encode these into any constraints since they are already satisfied by proof shape constraints or execution completeness checks, nor was the original issue asking us to.

For #226, sure, we can trigger a rebuild for bench_apps which will cause the resolver to update the P3 dependency.

#124, this comment will be updated

#144, I will add additional zip_eq invocations.

[eason1981]

LGTM