Skip to content

This is not compatible with wpvip #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lazardanlucian
Copy link

@lazardanlucian lazardanlucian commented Mar 5, 2021

can't activate plugin on WpVip, Automattic's own platform because of this!

Automattic's hosting WpVip GO is using advanced caching mechanisms and doesn't allow/expose the database
directly, only throught the wpsql api wpdb class.

I searched through the plugin and the plugin does not need DB_NAME,
only some test-scripts:

bin-wp/install-wp-tests.sh:9: DB_NAME=$1
bin-wp/install-wp-tests.sh:96: sed $ioption "s/youremptytestdbnamehere/$DB_NAME/" "$WP_TESTS_DIR"/wp-tests-config.php
bin-wp/install-wp-tests.sh:122: mysqladmin create $DB_NAME --user="$DB_USER" --password="$DB_PASS"$EXTRA

I'm not sure what the .sh are for, I can only hope they are for development purposes, because otherwise they might not work on many dockerised/contarinerised systems, etc.

Anyway, I'm pretty sure you don't need the:
if ( ! defined( 'DB_NAME' ) ) { header( 'HTTP/1.0 403 Forbidden' ); die; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants