Reverted String Class .to_a monkey patch #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.to_a method has been removed from the String class since Ruby 1.9 reference: https://stackoverflow.com/a/4465629/12131035
Rails caching code works with the assumption that .to_a can not be called on strings.
The following snippet below in the file Activesupport-6.0.3.2/lib/active_support/cache.rb, ends up in infinite recursion is .to_a method is called on Strings.
def expanded_version(key)
case
when key.respond_to?(:cache_version) then key.cache_version.to_param
when key.is_a?(Array) then key.map { |element| expanded_version(element) }.compact.to_param
when key.respond_to?(:to_a) then expanded_version(key.to_a)
end
end
This change is needed to ensure that rails and ruby code works as intended.