docs(pg.Pool): describe maxLifetimeSeconds config option
#3484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wording taken from brianc#3298 (comment)
birjj
changed the title
maxLifetimeSeconds to Pool docsmaxLifetimeSeconds config option
|
thanks for updating the docs! always super useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official
pg.Poolpage doesn't describe themaxLifetimeSecondsoption, which is nonetheless supported by the code, and present in the@types/pgpackage (it was added in #2698 all the way back in 2022). The lack of documentation makes it slightly difficult to discover the option.The wording I've used was taken from #3298 (comment). Feel free to change it if you're not happy with it.