Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hourly forecast endpoint #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Hourly forecast endpoint #55

wants to merge 1 commit into from

Conversation

GwennaelBuchet
Copy link

Hi,
this request add request to "hourly" weather (by step of 3 hours).

@GwennaelBuchet
Copy link
Author

Hi,
There are 2 tests from original sources that don't pass and break the build ("uv_test"), but all tests of this requests are OK.

Also, it seems Travis does not have a valid API key to run tests correctly.
Let me know if I have to change something or if can help.

Cheers

@briandowns
Copy link
Owner

This is great. Thank you very much! Can you put this functionality in the forecast.go file? There also appears to be some type overlap that can likely be avoided like HourlyForecastCitySys can just be the existting ForecastSys.

@GwennaelBuchet
Copy link
Author

Hi Brian,
thanks for your reply.
I try to find the time to do it this week-end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GwennaelBuchet @briandowns