Add Support for AddressRegex#72
Open
krutarth-h-dave wants to merge 2 commits intobriankabiro:masterfrom
Open
Conversation
krutarth-h-dave
commented
Sep 23, 2020
krutarth-h-dave
commented
…atches Sender with Regex
Author
|
Hi @briankabiro , Please check this and let me know if this works? Or there are some changes needed? I'll do. |
|
@briankabiro @krutarth-h-dave Guys any update on this? Would LOVE to use this functionality...😅 |
|
@krutarth-h-dave The addressRegex only takes numbers into consideration, but there are cases where the address can be purely letters or a mix of both. Would it be better to update the regex to capture other characters? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.