Fix SSSOM structural mapping column names for sssom-py compatibility#144
Open
justaddcoffee wants to merge 1 commit intomainfrom
Open
Fix SSSOM structural mapping column names for sssom-py compatibility#144justaddcoffee wants to merge 1 commit intomainfrom
justaddcoffee wants to merge 1 commit intomainfrom
Conversation
Rename subject_type → d4d_subject_range and object_type → rocrate_value_type to avoid colliding with reserved SSSOM columns that expect EntityTypeEnum values. Add fallback in SSSOMIntegration when sssom-py silently drops rows. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subject_type→d4d_subject_rangeandobject_type→rocrate_value_typein the structural mapping generator and regenerated the TSVSSSOMIntegrationwhensssom-pyreturns 0 rows after silent dropsContext
subject_typeandobject_typeare reserved SSSOM columns expectingEntityTypeEnumvalues (owl class,rdf property, etc.). The structural mapping was using these columns to store LinkML range names and Python types instead, which causedsssom-pyto silently reject all 149 rows. This resulted in thetest_load_structural_mappingCI failure.The column data is preserved under non-reserved names. No mapping content was changed.
Test plan
sssom-pyparses all 149 rows from the regenerated TSVtest_load_structural_mappingpasses withsssom-pyinstalled🤖 Generated with Claude Code