Skip to content

feature(#172): added safari support#197

Open
KunalKumar-1 wants to merge 3 commits into
briehq:developfrom
KunalKumar-1:feature/172-add-safari-support
Open

feature(#172): added safari support#197
KunalKumar-1 wants to merge 3 commits into
briehq:developfrom
KunalKumar-1:feature/172-add-safari-support

Conversation

@KunalKumar-1

@KunalKumar-1 KunalKumar-1 commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

Purpose of the PR*

#172 safari support

Priority*

  • High: This PR needs to be merged first, before other tasks.
  • Medium: This PR should be merged quickly to prevent conflicts due to common changes. (default)
  • Low: This PR does not affect other tasks, so it can be merged later.

Changes*

Screenshot 2025-06-06 at 10 10 04 PM

How to check the feature*

  • Open brie-extension in Xcode .
  • Select the "BrieExtension (macOS)" scheme
  • Press ⌘B (Build) to compile
  • and click the execute button on the upper left corner.
  • Load in Safari*
    Safari → Develop → Developer setting -> - [☑️] Allow unsigned extensions.

Reference

#172

@KunalKumar-1 KunalKumar-1 requested a review from ionleu as a code owner June 6, 2025 15:37
@github-actions github-actions Bot requested a review from LuminitaL June 6, 2025 15:37
@github-actions

github-actions Bot commented Jun 6, 2025

Copy link
Copy Markdown

Hey @KunalKumar-1,\nThanks for another PR! 🚀

@KunalKumar-1

Copy link
Copy Markdown
Contributor Author

let me know if any further changes to make .

@KunalKumar-1 KunalKumar-1 changed the title feature(172): added safari support feature(#172): added safari support Jun 6, 2025
@ionleu ionleu linked an issue Jun 6, 2025 that may be closed by this pull request
@ionleu

ionleu commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

Good job so far,
@KunalKumar-1 !

I have a few questions:

  • can we rename the root folder to safari-extension?
  • is hmr working? If we do some changes, are these reflected? Or we'll need to re-build/convert the extension?
  • can you put in a place a documentation for other devs to understand how we când continue developing/ maintaining the safari extension?

At the end,
I created a discussion topic, can you share there the entire process and/ or operations during working on this feature. See Discussions tab: Safari support topic.

@KunalKumar-1

KunalKumar-1 commented Jun 6, 2025

Copy link
Copy Markdown
Contributor Author
  • can we rename the root folder to safari-extension?

Ofcourse we can change the folder name to safari-extension.
i will change it to safari-extension

@KunalKumar-1

KunalKumar-1 commented Jun 6, 2025

Copy link
Copy Markdown
Contributor Author

is hmr working? If we do some changes, are these reflected? Or we'll need to re-build/convert the extension?

hmr seems to work,
But we need to do some changes for Safari's CSP
In Info.plist to enable rooting for wss://

by adding it to info.plist

<string>
  connect-src wss://localhost:8081 'self';
  script-src 'self' 'unsafe-inline';
</string>

then xcrun and ⌘ +B

@KunalKumar-1

Copy link
Copy Markdown
Contributor Author

can you put in a place a documentation for other devs to understand how we când continue developing/ maintaining the safari extension?

yup i will , please let me know the further details to do this.

@ionleu

ionleu commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

is hmr working? If we do some changes, are these reflected? Or we'll need to re-build/convert the extension?

hmr seems to work, But we need to do some changes in Safari's CSP In Info.plist to enable rooting for wss://

by adding it to info.plist

<string>
  connect-src wss://localhost:8081 'self';
  script-src 'self' 'unsafe-inline';
</string>

then xcrun and ⌘ +B

Was this added to info.plist?

Also,
is this an permanent solution?
I mean, no other devs will need to do this, since you'll add this to info.plist ?

@ionleu

ionleu commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

yup i will , please let me know the further details to do this.

You can put together a README.md file containing all necessary information and steps to run and develop the safari extension.

Signed-off-by: KUNAL KUMAR <kunaldevspro@gmail.com>
@KunalKumar-1 KunalKumar-1 force-pushed the feature/172-add-safari-support branch from 27dc69a to 143b685 Compare June 9, 2025 08:20
@KunalKumar-1

Copy link
Copy Markdown
Contributor Author

yup i will , please let me know the further details to do this.

You can put together a README.md file containing all necessary information and steps to run and develop the safari extension.

looking into it 🔥

@KunalKumar-1 KunalKumar-1 force-pushed the feature/172-add-safari-support branch 2 times, most recently from a885f3a to 143b685 Compare June 9, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Safari support

2 participants