feat(#110): adop vite build migration for all packages#213
Conversation
develop to main
|
Your PR was set to target |
|
Hey @saint0x, |
| @@ -1 +1 @@ | |||
| export * from './lib/index.js'; | |||
| export * from './lib/index'; | |||
There was a problem hiding this comment.
Are we not able to use this without the index path part?
There was a problem hiding this comment.
yes, since everything is now standardized it could be removed if you prefer -- kept it for explicitness
There was a problem hiding this comment.
Let's remove the index path from everywhere it still used.
| "@extension/tsconfig": "workspace:*" | ||
| "@extension/tsconfig": "workspace:*", | ||
| "@extension/vite-config": "workspace:*", | ||
| "vite": "6.1.0" |
There was a problem hiding this comment.
I think we should be good without installing vite in every package, since it is installed in the root. Or I'm wrong?
There was a problem hiding this comment.
the explicit references are necessary for individual package builds (if just working on one in isolation, for example)
There was a problem hiding this comment.
So if we'll use the root vite project the changes from here will not work properly?
There was a problem hiding this comment.
it will still work properly, just will be an extra step
There was a problem hiding this comment.
I'd prefer we use the one from the root. Will this add complexity to implement?
| @@ -1 +1 @@ | |||
| export * from './lib/plugins/index.js'; | |||
| export * from './lib/plugins/index'; | |||
There was a problem hiding this comment.
Still required to use index?
There was a problem hiding this comment.
As discussed above, we'll remove it
| export { ReduxProvider }; | ||
| export * from './lib/store/index.js'; | ||
| export * from './lib/hooks/index.js'; | ||
| export * from './lib/store/index'; |
There was a problem hiding this comment.
Same as other imports from above, still needs index?
There was a problem hiding this comment.
yep, same as others: explicit references are typically better to prevent potential future circular dependencies as well -- but if you don't like it, technically it could be removed.
| @@ -1 +1 @@ | |||
| export * from './lib/index.js'; | |||
| export * from './lib/index'; | |||
ionleu
changed the title
ionleu
added
improvements
|
@saint0x, |
2 participants
Purpose of the PR*
Migrated all packages to use a unified Vite build workflow and improved TypeScript declarations and configuration consistency across packages.
Priority*
Changes*
withLibraryConfigin each package's Vite config for consistency..jssuffixes in re-exports and alignedpackage.jsontypesfields with generated.d.(m)tsfiles.--skipLibCheckand added a sharedpackages/tsconfig/library.jsonto fix type declaration build issues.vite-config/lib/withLibraryConfig.tsto remove@extension/envand eliminate circular HMR/env dependency.zippertop-levelawaitissue by explicitly targetingnode18.Slice<…>generics to all Redux slices for improved type safety.tsconfig/distcopy workaround.anytype annotations.How to check the feature / Video Demo
Run
pnpm buildin each package and confirm:Reference