Skip to content

Move inner structs, enums and implementations to extensions #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Foundation

extension ElasticsearchClient {
public struct ValidationError: LocalizedError, Equatable {
public struct ValidationError: LocalizedError {
public static let invalidURLString = ValidationError(.invalidURLString)
public static let missingURLScheme = ValidationError(.missingURLScheme)
public static let invalidURLScheme = ValidationError(.invalidURLScheme)
Expand All @@ -12,28 +12,32 @@ extension ElasticsearchClient {
private let kind: Kind

private init(_ kind: Kind) { self.kind = kind }
}
}

extension ElasticsearchClient.ValidationError: Equatable {
public static func ==(lhs: ElasticsearchClient.ValidationError, rhs: ElasticsearchClient.ValidationError) -> Bool {
return lhs.kind == rhs.kind
}
}

extension ElasticsearchClient.ValidationError {
private enum Kind: LocalizedError {
case invalidURLString
case missingURLScheme
case invalidURLScheme
case missingURLHost

public static func ==(lhs: ValidationError, rhs: ValidationError) -> Bool {
return lhs.kind == rhs.kind
}

private enum Kind: LocalizedError {
case invalidURLString
case missingURLScheme
case invalidURLScheme
case missingURLHost

var localizedDescription: String {
let message: String = {
switch self {
case .invalidURLString: return "invalid URL string"
case .missingURLScheme: return "URL scheme is missing"
case .invalidURLScheme: return "invalid URL scheme, expected 'http' or 'https'"
case .missingURLHost: return "missing remote hostname"
}
}()
return "Elasticsearch connection configuration validation failed: \(message)"
}
var localizedDescription: String {
let message: String = {
switch self {
case .invalidURLString: return "invalid URL string"
case .missingURLScheme: return "URL scheme is missing"
case .invalidURLScheme: return "invalid URL scheme, expected 'http' or 'https'"
case .missingURLHost: return "missing remote hostname"
}
}()
return "Elasticsearch connection configuration validation failed: \(message)"
}
}
}
Original file line number Diff line number Diff line change
@@ -1,19 +1,25 @@
import Foundation

public struct ESGetMultipleDocumentsResponse<Document: Decodable>: Decodable {
public struct Hits: Decodable {
public struct Total: Decodable {
public let value: Int
public let relation: Relation

public enum Relation: String, Decodable {
case eq, gte
}
}
public let hits: Hits
}

extension ESGetMultipleDocumentsResponse {
public struct Hits: Decodable {
public let total: Total?
public let hits: [ESGetSingleDocumentResponse<Document>]
}
}

public let hits: Hits
extension ESGetMultipleDocumentsResponse.Hits {
public struct Total: Decodable {
public let value: Int
public let relation: Relation
}
}

extension ESGetMultipleDocumentsResponse.Hits.Total {
public enum Relation: String, Decodable {
case eq, gte
}
}