Skip to content

fix: correctly save and load configs in UI #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marginal23326
Copy link
Contributor

@marginal23326 marginal23326 commented Mar 29, 2025

  • Fixed saving UI configs (previously, it would only save the default configs).
  • Fixed to correctly set the model name in the UI from the config even when it's a custom one.

@vvincent1234
Copy link
Contributor

def save_current_config(self, *component_values):
I think we do not need to input component_values to save_current_config fn and we should use components saved in config_manager, because the value of components may change during using.

@marginal23326 marginal23326 force-pushed the fix/config-model-save-load branch from 6fe4532 to fc8a31d Compare March 30, 2025 01:47
@marginal23326
Copy link
Contributor Author

@vvincent1234

updated the logic to use the manager's state directly; it should be alright now.

@marginal23326 marginal23326 changed the title fix: correctly save and load model name in UI fix: correctly save and load configs in UI Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants