-
Couldn't load subscription status.
- Fork 56
Change Binary Download Distribution #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the binary download distribution functionality by modifying the API of the binaryPath method and enhancing error handling. Key changes include:
- Updating calls to binaryPath in tests to incorporate additional parameters (key and retries).
- Introducing a new module (fetchDownloadSourceUrl.js) to retrieve download endpoints.
- Changing the binary download logic and error reporting in LocalBinary.js and Local.js to support updated configurations.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/local.js | Updated tests to pass additional parameters to binaryPath. |
| lib/fetchDownloadSourceUrl.js | New module to fetch download source URL over HTTPS. |
| lib/LocalBinary.js | Modified binaryPath API and improved error handling in downloads. |
| lib/Local.js | Adjusted retries and updated binaryPath invocations accordingly. |
Comments suppressed due to low confidence (1)
test/local.js:283
- [nitpick] Document the use of the hard-coded test values ('abc' for key and 9 for retries) so that their purpose is clear to future maintainers.
(new LocalBinary()).binaryPath({}, 'abc', 9, function(binaryPath) {
No description provided.