merge update #1
Open
merge update #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove script runner and hints at the top
Use random.seed for deterministic doctest outputs
Fix simple typo: insided -> inside
Add more doctests
More doctests
change "as it make.." to "as it makes.."
Fix prototype.py typo
Test order randomization
Added alternative implementation for Iterator pattern using the Iterator protocol
add a little more description and references
- Changed __init__ in AbstractExpert to abstract method - Added comments
Abstract factory fixes
* Removed old Python versions * Removed 3.10 from tox and upgraded requirements-dev.txt becasue of higher versions in lint.sh * 3.13 changed to 3.12 * Adjusted lint_python workflow Upgraded flake8 to 7.1 * Added continue-on-error: true. So that if the workflow stop comes in error, it will continue. * Added workflow to check per PR * Moved workflow * Changed name workflow * Changed job name * Added approval for non-Python files and removed continue-on-error * Optimzed lint_pr.yml * Added fix for PyTest * Let pytest only test on changed python design patterns * Optimized Tox * Allow tox execute it's checks * Tox optimization 2 * Optimized check * Ignore setup.py from linting unless it is changes * Fixed bug * Testing a idea * Revert idea * added __init__.py to tests/ for tox * Let tox only test on Python files that are in the PR. * Adjusted .coveragerc * added usedevelop = true to tox.ini * Change cov from patterns to main * Rewrote check. * retry fixing coverage * Change cov to main * Added coverage run to execute pytest * changed cov to patterns * created pyproject.toml and moved old config to backup folder * Testing * Changed opts to doctest * Fix for error Unknown config option: randomly_seed * Trying fix for No data was collected. (no-data-collected) * Changed source from patterns to ./ * Changed source from patterns to ./
* Removed old Python versions * Added typing * Fixed bug * Removed bugs and added more types * Fixed bug on check if controller is defined * removed object definition from routes * I fixed a bug * Ädded comments and lost types * Fixed types for Router * Fixed lines * yeah sure * List dammit! * . * oops * .
* Migrates to pyproject.toml Switches the build system from setup.py to pyproject.toml. This change standardizes the project's build configuration, improves dependency management, and prepares the project for future enhancements. Removes unused requirements file. * Updates minimum Python version Corrects the minimum Python version specified in pyproject.toml. The project now requires Python 3.10 or higher. * Uses installable package for dev dependencies Updates the installation of development dependencies in the linting workflow to use the installable package. This simplifies dependency management and aligns with standard Python packaging practices. * Adds pyupgrade as a dev dependency Adds `pyupgrade` to the development dependencies. This enables developers to automatically upgrade Python syntax to more modern versions, improving code maintainability and readability.
* Add docstring for Servant behavioral design pattern * Implement Servant class * Add docstest examples * Add testing for Servant class * Use fixtures for circle and rectangle
Use ellipsis replace pass to avoid potential warning: ``` "resource": "/d:/Github/Python/python-patterns/patterns/creational/factory.py", "owner": "pylance4", "value": "reportReturnType", "path": "/microsoft/pylance-release/blob/main/docs/diagnostics/reportReturnType.md", "severity": 8, "message": "Function with declared return type \"str\" must return value on all code paths\n \"None\" is not assignable to \"str\"", "source": "Pylance", "startLineNumber": 29, "startColumn": 37, "endLineNumber": 29, "endColumn": 40, "origin": "extHost1" }] ``` Using VS Code with Pylance, Python debugger, and Black Formatter.
* Remove pluggable-libs submodule and cleanup (#433) * Fix GitHub Actions output format error for multiline file lists * Add requirements-dev.txt so CI can install dev dependencies --------- Co-authored-by: Sakis Kasampalis <[email protected]>
Co-authored-by: Benjamin Townsend <[email protected]> Co-authored-by: Sakis Kasampalis <[email protected]>
* Adding typehint * Update __exit__ type * fix black formatting --------- Co-authored-by: Roy, Debakar <[email protected]> Co-authored-by: Sakis Kasampalis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge update request