-
Notifications
You must be signed in to change notification settings - Fork 0
Issue #67: Physicell mechanics skeleton #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/mech-orig
Are you sure you want to change the base?
Conversation
|
Format your code using |
asmelko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more recommendations:
- fix all the previous comments and mark them resolved if you think it is done
- link all the issues that this PR solves into the Development tab on the right
- if you want a review from somebody, link them as reviewers in Reviewers tab on the right - if you want to have your new changes re-reviewed, click on request review next to the reviewer so that they are notified
- ensure that all checks pass before requesting another review (currently clang-tidy formal check fails, try running
run-clang-tidy -p [YOUR_BUILD_DIR](with-fixflag) to see the errors locally
|
Also, add the new tests binary into sonar automation ( |
asmelko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work with config reader!
lets improve the coverage and remove duplication and it will be ready to merge
asmelko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please no new features in this PR!
|


No description provided.