Skip to content

Conversation

@joseestraguesbsc
Copy link
Contributor

No description provided.

@asmelko asmelko self-requested a review December 3, 2025 07:14
@asmelko
Copy link
Contributor

asmelko commented Dec 3, 2025

Format your code using git ls-files -z -- '*.h' '*.hpp' '*.hh' '*.hxx' '*.c' '*.cc' '*.cpp' '*.cxx' '*.cu' | xargs -0 -n1 clang-format -i -style=file as suggested in the failing check

@asmelko asmelko self-requested a review December 4, 2025 09:39
@joseestraguesbsc joseestraguesbsc changed the base branch from main to feature/mech-orig December 4, 2025 10:42
@asmelko asmelko linked an issue Dec 4, 2025 that may be closed by this pull request
Copy link
Contributor

@asmelko asmelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more recommendations:

  • fix all the previous comments and mark them resolved if you think it is done
  • link all the issues that this PR solves into the Development tab on the right
  • if you want a review from somebody, link them as reviewers in Reviewers tab on the right - if you want to have your new changes re-reviewed, click on request review next to the reviewer so that they are notified
  • ensure that all checks pass before requesting another review (currently clang-tidy formal check fails, try running run-clang-tidy -p [YOUR_BUILD_DIR] (with -fix flag) to see the errors locally

@asmelko
Copy link
Contributor

asmelko commented Dec 4, 2025

Also, add the new tests binary into sonar automation (sonarqube.yml).
Follow the flow of mechanics.micromechanics.tests inside the file, add mechanics.physicell.tests, the sources and tests under --define sonar.sources and --define sonar.tests

Copy link
Contributor

@asmelko asmelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work with config reader!
lets improve the coverage and remove duplication and it will be ready to merge

Copy link
Contributor

@asmelko asmelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please no new features in this PR!

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Mechanics_OG] Add simulation parameters struct

4 participants