-
Notifications
You must be signed in to change notification settings - Fork 11
Update default python version #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙋♀️
|
||
LATEST_PKG_PYTHON_VERSION != pkg info -g 'python3*' | cut -d'-' -f1 | sed 's/^python//' | sort -n | tail -n1 | sed -r 's/^([0-9])([0-9]+)/\1.\2/' | ||
PYTHON ?= python${LATEST_PKG_PYTHON_VERSION} | ||
pyver= ${PYTHON:S/^python//:S/.//:C/\([0-9]+\)/\1/} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given that we already have LATEST_PYTHON_VERSION
we can use this directly here
Makefile
Outdated
|
||
LATEST_PKG_PYTHON_VERSION != pkg info -g 'python3*' | cut -d'-' -f1 | sed 's/^python//' | sort -n | tail -n1 | sed -r 's/^([0-9])([0-9]+)/\1.\2/' | ||
PYTHON ?= python${LATEST_PKG_PYTHON_VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should still have a fallback, since we use this makefile on Travis, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit complicated. There are multiple layers of overrides happening here.
PYTHON_VERSION ?= $(TRAVIS_PYTHON_VERSION)
SELECTED_PYTHON_VERSION != if [ "$(PYTHON_VERSION)" != "" ]; then echo $(PYTHON_VERSION); else pkg info -g 'python3*' | cut -d'-' -f1 | sed 's/^python//' | sort -n | tail -n1 | sed -r 's/^([0-9])([0-9]+)/\1.\2/'; fi
PYTHON ?= python${SELECTED_PYTHON_VERSION}
pyver= ${PYTHON:S/^python//:S/.//:C/\([0-9]+\)/\1/}
1.) When no PYTHON_VERSION
was set, use TRAVIS_PYTHON_VERSION
2.) If neither was set, guess SELECTED_PYTHON_VERSION
using pkg info
3.) This all can be overwritten via PYTHON
.
4.) Read numeric pyver
of whatever version was selected
Pkg is not available on Travis (Linux), but a PYTHON_VERSION env variable is set
3be5ab5
to
02b3780
Compare
addresses an update of Python Typeshed
bf2575f
to
2906aa4
Compare
4d60330
to
cbb3037
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lies and half truths.
make PYTHON=python3.8 install | ||
``` | ||
|
||
At the current time libioc is not packaged or available in FreeBSD ports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not entirely true…
https://www.freshports.org/devel/py-libioc it just… still doesn't have all the right dependencies…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, let's tackle this at a different time. Would you open an Issue as a reminder? 💜
cbb3037
to
2ff6c52
Compare
2ff6c52
to
71f058e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving this despite the failing vnet tests
We can tackle these separately
5637df9
to
eba2847
Compare
addresses #750