Closed
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
shruggr
approved these changes
Mar 12, 2026
shruggr
added a commit
to b-open-io/go-sdk
that referenced
this pull request
Mar 12, 2026
…n#302) Co-Authored-By: Claude Opus 4.6 <[email protected]>
shruggr
added a commit
that referenced
this pull request
Mar 12, 2026
* Fix ComputeMissingHashes not handling odd node counts at intermediate levels When a Merkle tree level has an odd number of nodes, Bitcoin duplicates the last node to form a pair. ComputeMissingHashes only handled this at level 0 via explicit Duplicate markers but never propagated them to higher levels. This caused incomplete proofs when building full trees from transaction hashes (e.g. in Arcade), leaving the top-level sibling missing and causing "Missing hash for index N at height M" errors on the client side during BEEF verification. * update changelog for v1.2.19 Co-Authored-By: Claude Opus 4.6 <[email protected]> * Include dependabot updates: x/crypto, x/net, x/sync, upload-artifact Co-Authored-By: Claude Opus 4.6 <[email protected]> * Update CI Go version from 1.24 to 1.25 to match go.mod Co-Authored-By: Claude Opus 4.6 <[email protected]> * Bump golangci-lint from v2.1.6 to v2.11.2 for Go 1.25 compat Co-Authored-By: Claude Opus 4.6 <[email protected]> * feat: distinction between RequireAckAll and RequireNone * chore: update default SLAP trackers * chore: increase default SHIP timeout * Include overlay broadcaster fixes in v1.2.19 changelog (#302) Co-Authored-By: Claude Opus 4.6 <[email protected]> --------- Co-authored-by: Claude Opus 4.6 <[email protected]> Co-authored-by: Paweł Lewandowski <[email protected]>
Collaborator
|
Included in v1.2.19 release via #298 (squash merged) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR improves the resiliency of the Overlay Service host discovery process in the go-sdk. It aligns the default SLAP tracker configuration and query timeouts with the @bsv/sdk (TypeScript) implementation.
Fixes:
RequireAckAllandRequireNone(based on TS version and empty topic array)error="context deadline exceeded"), 5s allows to get at least one success responseTesting Procedure
This issues was found when working on
go-uhrp-storage-server