Skip to content

Conversation

@mrz1836
Copy link
Collaborator

@mrz1836 mrz1836 commented Jan 29, 2026

What Changed

  • Synchronized 8 file(s) from directory mappings
  • Applied file transformations and updates based on sync configuration
  • Brought target repository in line with source repository state at commit c288610

Directory Synchronization Details

The following directories were synchronized:

.github/ISSUE_TEMPLATE.github/ISSUE_TEMPLATE

  • Files synced: 0
  • Files examined: 3
  • Files excluded: 0
  • Processing time: 523ms

.github/actions.github/actions

  • Files synced: 1
  • Files examined: 17
  • Files excluded: 0
  • Processing time: 1062ms

.github/scripts.github/scripts

  • Files synced: 0
  • Files examined: 1
  • Files excluded: 0
  • Processing time: 422ms

.github/tech-conventions.github/tech-conventions

  • Files synced: 0
  • Files examined: 14
  • Files excluded: 0
  • Processing time: 932ms

.github/workflows.github/workflows

  • Files synced: 7
  • Files examined: 26
  • Files excluded: 0
  • Processing time: 1522ms

.vscode.vscode

  • Files synced: 0
  • Files examined: 4
  • Files excluded: 0
  • Processing time: 518ms

Performance Metrics

  • Files processed: 88 (8 changed, 0 deleted, 80 skipped)
  • Files attempted to change: 8 (go-broadcast processing)
  • File processing time: 10319ms

Why It Was Necessary

This synchronization ensures the target repository stays up-to-date with the latest changes from the configured source repository. The sync operation identifies and applies only the necessary file changes while maintaining consistency across repositories.

Testing Performed

  • Validated sync configuration and file mappings
  • Verified file transformations applied correctly
  • Confirmed no unintended changes were introduced
  • All automated checks and linters passed

Impact / Risk

  • Low Risk: Standard sync operation with established patterns
  • No Breaking Changes: File updates maintain backward compatibility
  • Performance: No impact on application performance
  • Dependencies: No dependency changes included in this sync

Copilot AI review requested due to automatic review settings January 29, 2026 19:54
@mrz1836 mrz1836 self-assigned this Jan 29, 2026
@mrz1836 mrz1836 added automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps labels Jan 29, 2026
@github-actions github-actions bot added size/L Large change (201–500 lines) update General updates labels Jan 29, 2026
@sonarqubecloud
Copy link

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR synchronizes workflow files from the source repository (mrz1836/go-broadcast), primarily removing the custom workflow cancellation mechanism and adjusting permissions accordingly. The changes disable the cancel-workflow-on-failure action that was overwriting failure statuses with cancelled statuses, making it difficult to identify which jobs actually failed.

Changes:

  • Removed actions: write permissions from jobs that no longer need to cancel workflows
  • Changed actions: write to actions: read for the test suite job that only needs artifact access
  • Removed all invocations of the cancel-workflow-on-failure action from workflow steps
  • Added documentation explaining why the cancellation action is not in use
  • Refactored the results summary in fortress.yml to use bash functions for better maintainability

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/fortress.yml Removed actions: write permissions from security, pre-commit, and code-quality jobs; changed test-suite from actions: write to actions: read; refactored results summary to use bash functions
.github/workflows/fortress-test-suite.yml Removed actions: write permissions from test matrix and fuzz test execution jobs
.github/workflows/fortress-test-matrix.yml Removed actions: write permission and workflow cancellation step from test job
.github/workflows/fortress-test-fuzz.yml Removed actions: write permission and workflow cancellation step from fuzz test job
.github/workflows/fortress-security-scans.yml Removed actions: write permissions and workflow cancellation steps from Nancy, Govulncheck, and Gitleaks jobs
.github/workflows/fortress-pre-commit.yml Removed actions: write permission and workflow cancellation step from pre-commit job
.github/workflows/fortress-code-quality.yml Removed actions: write permissions and workflow cancellation steps from Go vet, lint, and YAML/JSON format validation jobs
.github/actions/cancel-workflow-on-failure/action.yml Added documentation explaining the action is not in use due to status overwriting issues

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mrz1836
Copy link
Collaborator Author

mrz1836 commented Jan 29, 2026

LGTM!

@mrz1836 mrz1836 merged commit ef01e3f into master Jan 29, 2026
50 checks passed
@github-actions github-actions bot deleted the chore/sync-files-bsv-blockchain-template-20260129-145431-fd7333d branch January 29, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps size/L Large change (201–500 lines) update General updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant