Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR syncs workflow configuration from the source repo and enhances CI reporting, focusing on more robust input parsing, clearer status visibility, and richer but more compact configuration and completion summaries.
Changes:
- Update multiple workflows to pin
actions/cacheto v5.0.3 and add explicit::errorannotations for key failure paths (tests, benchmarks, pre-commit, release) to surface issues prominently in the Actions UI. - Redesign the configuration summary (
fortress-setup-config.yml) and completion report finalization (fortress-completion-finalize.yml) to use collapsible sections, normalized input keys, and safer parsing of JSON/multiline data via base64 + heredocs. - Improve final workflow reporting by computing an explicit pass/fail banner from individual job results, summarizing timing and matrix statistics, and structuring fork PR and performance insights into clearly separated, collapsible sections.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/fortress.yml |
Bumps the GoFortress workflow version metadata from 1.5.0 to 1.6.0 to reflect the synchronized changes. |
.github/workflows/fortress-test-matrix.yml |
Adds a ::error annotation when a matrix test run fails so test failures show as top-level annotations in the Actions UI. |
.github/workflows/fortress-setup-config.yml |
Refactors the configuration summary into a compact always-visible header plus multiple <details> sections, adds feature/matrix counts and refined tables for core CI, feature flags, benchmarks, coverage, Redis, pre-commit, security tools, auth, custom vars, and env listings. |
.github/workflows/fortress-security-scans.yml |
Updates the actions/cache pin for the govulncheck binary cache to the newer v5.0.3 SHA. |
.github/workflows/fortress-release.yml |
Updates actions/cache for golangci-lint cache to v5.0.3 and adds ::error annotations for invalid GoReleaser config and release failures to make release issues more visible. |
.github/workflows/fortress-pre-commit.yml |
Updates all actions/cache usages to v5.0.3 and emits a ::error annotation when pre-commit checks fail to surface code-quality problems in the summary. |
.github/workflows/fortress-coverage.yml |
Updates go-coverage related actions/cache invocations (prod/local binaries) to the v5.0.3 pin. |
.github/workflows/fortress-completion-finalize.yml |
Reworks input parsing using base64 + heredocs with hyphen-to-underscore key normalization, introduces a status banner and job results table at the top of the final report, nests statistics/tests/performance into structured <details>, and updates fork PR / release handling and timing insights accordingly. |
.github/workflows/fortress-code-quality.yml |
Updates all golangci-lint cache-related actions/cache steps to v5.0.3. |
.github/workflows/fortress-benchmarks.yml |
Changes the benchmark failure log to a more descriptive ::error annotation, clarifying that benchmark failures include panic/fatal/timeout conditions and pointing readers to job details. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What Changed
.github/workflows/fortress-completion-finalize.ymlto use base64 encoding for safer parsing of workflow inputs and timing dataenv-jsonbecomesenv_json) for GitHub Actions expression compatibility<<EOF_INPUT_*) to safely handle multiline values in environment variablesALL_INPUTSandTIMING_DATAprocessing loopsWhy It Was Necessary
IFS='=' read -r key value) could fail with multiline values like JSON content, causing parsing errors in the workflowTesting Performed
env-json) process correctly without truncation or parsing errorsImpact / Risk