Skip to content

[Sync] Update project files from source repository (425438b)#98

Merged
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bsv-blockchain-sdks-20260130-130344-425438b
Jan 30, 2026
Merged

[Sync] Update project files from source repository (425438b)#98
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bsv-blockchain-sdks-20260130-130344-425438b

Conversation

@mrz1836
Copy link
Collaborator

@mrz1836 mrz1836 commented Jan 30, 2026

What Changed

  • Updated the "Parse workflow inputs and timing data" step in fortress-completion-finalize.yml to use base64 encoding for safe handling of multiline values (e.g., env-json)
  • Modified key-value parsing to use heredoc syntax (<<EOF) instead of simple assignment to prevent issues with multiline environment variable values
  • Added key normalization that replaces hyphens with underscores for GitHub Actions expression compatibility (e.g., env-json becomes env_json)
  • Changed the "Initialize Final Report" step to start with a STATUS BANNER FIRST, including logic to determine overall workflow status and track failed jobs before generating the report header

Why It Was Necessary

  • The previous simple key=value assignment method could not safely handle multiline JSON values (like env-json input), causing parsing failures or truncated environment variables
  • GitHub Actions expressions cannot reference environment variables with hyphens in their names, requiring normalization to underscores
  • Starting the final report with status banner first provides immediate visibility into workflow success/failure before displaying detailed results

Testing Performed

  • Workflow changes should be validated by running the completion finalize workflow with inputs containing multiline JSON data
  • Verify that environment variables with normalized keys (underscores instead of hyphens) are correctly accessible in subsequent steps
  • Confirm that the final report displays the status banner at the top and correctly identifies failed jobs

Impact / Risk

  • Low Risk: Changes improve robustness of input parsing without altering the workflow's core logic or external interfaces
  • Compatibility: Key normalization ensures environment variables are accessible in all GitHub Actions expression contexts
  • Report Structure: The reordering of report initialization places status information more prominently, improving readability for workflow consumers

@mrz1836 mrz1836 self-assigned this Jan 30, 2026
@mrz1836 mrz1836 added automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps labels Jan 30, 2026
@github-actions github-actions bot added size/XL Very large change (>500 lines) update General updates labels Jan 30, 2026
@sonarqubecloud
Copy link

@mrz1836
Copy link
Collaborator Author

mrz1836 commented Jan 30, 2026

LGTM!

@mrz1836 mrz1836 merged commit ab4aa88 into master Jan 30, 2026
44 checks passed
@github-actions github-actions bot deleted the chore/sync-files-bsv-blockchain-sdks-20260130-130344-425438b branch January 30, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps size/XL Very large change (>500 lines) update General updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant