Feature/cleanuporphanedtransactions

[liam]

No description provided.

[github-actions]

🤖 Claude Code Review

Status: Complete

---

Issues Found

Critical

cmd/cleanup-orphaned-external/main.go:100 - Type switch bug
The switch statement case int, int64: will not work as intended in Go. Type switches cannot match multiple types in one case. This should be separate cases or use type conversion.

cmd/cleanup-orphaned-external/main.go:144 - File path assumption
The code assumes external files are named {txID}.tx, but this may not match the actual naming convention used by stores/utxo/. Verify this matches reality to avoid deleting valid records or missing orphans.

Moderate

cmd/cleanup-orphaned-external/main.go:160 - Race condition in progress reporting
Multiple scan goroutines could simultaneously trigger the progress print when scanned % 100000 == 0. While not critical, this could cause duplicate or interleaved output.

cmd/cleanup-orphaned-external/main.go:62 - Nil policy parameter
Using nil for the delete policy may have undefined behavior. Consider using aero.NewWritePolicy() explicitly.

---

Other Observations

The P2P and block validation changes look reasonable:

• Cleaner distinction between "malicious" (banned) and "unhealthy" (low reputation) peers
• Better fallback logic when primary catchup peer fails
• Improved backoff mechanism when all peers are exhausted

The sync coordinator changes improve resilience by clearing sync attempts when entering backoff, allowing fresh retries after the backoff period expires.

[sonarqubecloud]

Quality Gate failed

Failed conditions
19.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud