Skip to content

4433: fix aerospike docker restart#370

Open
liam wants to merge 1 commit intobsv-blockchain:mainfrom
liam:feature/aerospiketimeout
Open

4433: fix aerospike docker restart#370
liam wants to merge 1 commit intobsv-blockchain:mainfrom
liam:feature/aerospiketimeout

Conversation

@liam
Copy link
Collaborator

@liam liam commented Jan 9, 2026

No description provided.

@liam liam requested a review from oskarszoon January 9, 2026 07:31
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

🤖 Claude Code Review

Status: Complete


This PR contains two unrelated changes:

  1. Aerospike timeout increase (deploy/docker/base/aerospike-asmt-wrapper.sh): Extends ready timeout from 5 to 15 minutes. Changes are technically sound with proper shellcheck compliance improvements.

  2. Golangci linter re-enablement (.golangci.json): Re-enables several linters that were previously disabled (whitespace, staticcheck, unconvert, goconst, gocritic, gocognit). These linters are now in the enable list.

Concerns:

The linter changes are unrelated to the stated PR purpose (fix aerospike docker restart) and may cause widespread lint failures across the codebase. Consider splitting into a separate PR to allow independent testing and rollback if needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes shouldn't be in this PR, better handled in a different PR because it requires a lot of fixes ot the code to get the linter green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants