benchtest: scaffold

[sugh01]

No description provided.

[github-actions]

🤖 Claude Code Review

Status: Complete

---

Current Review:

This PR introduces a benchmark comparison framework with CI automation. The implementation is solid with one minor issue:

Issues Found:

1. Unused type in parse-benchmarks - The gitInfo struct is defined but never used

Positive aspects:

• Clean separation of concerns (parse, compare, CI orchestration)
• Good error handling throughout
• Proper use of mock data for scaffolding phase
• File permissions correctly set (0o600)
• Follows project conventions for the most part

History:

• ✅ Fixed: File naming now correctly uses snake_case (handlers_benchmark_test.go)

[github-actions]

🤖 Claude Code Review

Status: Complete

---

Summary

This PR introduces a benchmark comparison framework for tracking performance across PRs. The implementation is solid and includes GitHub Actions workflow automation, benchmark parsing tools, and comparison reporting.

Issues Found

Critical:
None

Moderate:

1. File naming convention violation in services/asset/httpimpl/handlers_bench_test.go - Should use snake_case with full words per project conventions (e.g., handlers_benchmark_test.go)

2. Unused type definition in cmd/parse-benchmarks/main.go:30 - The gitInfo struct is defined but never used. Either remove it or use it in the benchmarkRun struct.

3. Silent error handling in cmd/parse-benchmarks/main.go:136 - The parseInt64 function ignores parse errors silently. Consider logging errors or returning error values for easier debugging.

Minor:

4. Comment spam potential in .github/workflows/benchmark-compare.yaml:204 - Workflow creates a new comment on each run. Consider updating existing comments instead to avoid clutter.

5. Mock data dependency in workflow - Uses relative paths to mock data which could be fragile if file structure changes.

---

This is an advisory review. Human reviewers make final approval decisions.

[github-actions]

File naming convention violation

According to the project coding conventions (docs/references/codingConventions.md), test file names should use snake_case format. This file should be renamed to handlers_bench_test.go -> handlers_benchmark_test.go or similar.

From the conventions:

Use snake_case: File names should use all lowercase letters with words separated by underscores (e.g., block_header_test.go)

While "bench" is short for "benchmark", the project consistently uses descriptive names. Consider renaming to maintain consistency with the codebase.

[github-actions]

The gitInfo type is defined but never used. The code uses map[string]string directly instead. Consider removing this unused type to reduce code clutter.

[sonarqubecloud]

Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE